-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Brave News] Remove Brave News Subscribe button flag #16009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ 👍🏼
ed94d05
to
ae4bb10
Compare
A Storybook has been deployed to preview UI for the latest push |
ae4bb10
to
2b6dfc8
Compare
A Storybook has been deployed to preview UI for the latest push |
1336c3d
to
5bc53a4
Compare
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chromium_src
lgtm.
A Storybook has been deployed to preview UI for the latest push |
b73b96b
to
9c5f08f
Compare
A Storybook has been deployed to preview UI for the latest push |
Verified
|
Brave | 1.48.17 Chromium: 108.0.5359.71 (Official Build) nightly (x86_64) |
---|---|
Revision | 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016} |
OS | macOS Version 13.1 (Build 22C5050e) |
Steps:
- installed
1.48.17
- launched Brave
- opened
brave://flags
- looked for
brave://flags/#brave-news-subscribe-button
and ensured it's missing - loaded
theatlantic.com
- wait
- confirmed the new RSS-feed icon(s) in the URL bar appear(s) by default, now, and are functional
Screenshots:
example |
example |
example |
example |
example |
---|---|---|---|---|
[Brave News] Remove Brave News Subscribe button flag (#16009)
Resolves brave/brave-browser#26847
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: